Skip to content

fix: capture:wrap boolean and table with errorable __index #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: capture:wrap boolean and table with errorable __index #332

wants to merge 1 commit into from

Conversation

d-enk
Copy link

@d-enk d-enk commented Oct 13, 2023

Output correct message instead crash for:

error(false)
--- false
...
stack traceback: ...

and

error(setmetatable({}, { __index = error })) -- object with field validation
--- []
...
stack traceback: ...

Current behavior

/luarocks/share/tarantool/luatest/runner.lua:259: error in error handling
stack traceback:
        /luarocks/share/tarantool/luatest/capturing.lua:81: in function </luarocks/share/tarantool/luatest/capturing.lua:74>
        [C]: in function 'bootstrap'
        /luarocks/share/tarantool/luatest/runner.lua:259: in function </luarocks/share/tarantool/luatest/runner.lua:258>
        [C]: in function 'xpcall'
        /luarocks/share/tarantool/luatest/capturing.lua:74: in function </luarocks/share/tarantool/luatest/capturing.lua:72>
        [C]: in function 'xpcall'
        /luarocks/share/tarantool/luatest/runner.lua:51: in function 'fn'
        /luarocks/share/tarantool/luatest/sandboxed_runner.lua:14: in function 'run'
        /luarocks/share/tarantool/luatest/cli_entrypoint.lua:4: in function </luarocks/share/tarantool/luatest/cli_entrypoint.lua:3>
        /luarocks/share/tarantool/rocks/luatest/0.5.7-1/bin/luatest:3: in main chunk

@kyukhin kyukhin requested a review from ylobankov November 17, 2023 07:46
@ylobankov ylobankov assigned ochaplashkin and unassigned ylobankov Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylobankov ylobankov Awaiting requested review from ylobankov

At least 1 approving review is required to merge this pull request.

Assignees

@ochaplashkin ochaplashkin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-enk @ylobankov @ochaplashkin